-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/CDP-174-LandingFeature1 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ก Codex Review
Here are some automated review suggestions for this pull request.
โน๏ธ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with ๐.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export const FEATURES: FeatureItem[] = [ | ||
| { | ||
| title: "์ผ๊ฐ", | ||
| description: "์ค๋์ ์ผ์ ๊ณผ ํ ์ผ์ ํ๋์", | ||
| iconName: "calendar", | ||
| previewImageSrc: "/images/feature-daily.png", | ||
| }, | ||
| { | ||
| title: "์ฃผ๊ฐ", | ||
| description: "์ผ์ฃผ์ผ ๋จ์๋ก ๊ณํ์ ์ธ์ฐ๊ณ ๊ด๋ฆฌ", | ||
| iconName: "calendarDays", | ||
| previewImageSrc: "/images/feature-weekly.png", | ||
| }, | ||
| { | ||
| title: "์๊ฐ", | ||
| description: "ํ ๋ฌ ์ ์ฒด ์ผ์ ์ ์กฐ๋งํ๊ณ ๊ณํ", | ||
| iconName: "calendarRange", | ||
| previewImageSrc: "/images/feature-monthly.png", | ||
| }, | ||
| { | ||
| title: "To-Do", | ||
| description: "ํด์ผ ํ ์ผ์ ์ฒด๊ณ์ ์ผ๋ก ์ ๋ฆฌ", | ||
| iconName: "checkSquare", | ||
| previewImageSrc: "/images/feature-todo.png", | ||
| }, | ||
| { | ||
| title: "์ต๊ด", | ||
| description: "์ข์ ์ต๊ด์ ๋ง๋ค๊ณ ์ง์์ ์ผ๋ก ์ถ์ ", | ||
| iconName: "rotateCcw", | ||
| previewImageSrc: "/images/feature-habit.png", | ||
| }, | ||
| { | ||
| title: "๋ฉ๋ชจ", | ||
| description: "์ค์ํ ์๊ฐ๊ณผ ์์ด๋์ด๋ฅผ ๊ธฐ๋ก", | ||
| iconName: "stickyNote", | ||
| previewImageSrc: "/images/feature-memo.png", | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provide assets for Landing feature previews
The new FEATURES metadata references six local preview images (e.g. "/images/feature-daily.png") that are rendered in LandingFeaturesSection1, but the public/images directory only contains logo.png. At runtime the preview <Image> in the landing page will try to load these files and each request will return 404, so the main visual element of the new feature section will appear broken. Please add the images or point the constants at existing assets.
Useful? React with ๐ย / ๐.
๐ Pull Request
๐ PR ์ ํ
๐ ๋ณ๊ฒฝ ์ฌํญ
MainSection ์ปดํฌ๋ํธ CSS ๋ฆฌํฉํ ๋ง
FeatureSection1 ์ปดํฌ๋ํธ ์ถ๊ฐ
FeatureGrid ์ปดํฌ๋ํธ ์ถ๊ฐ
๐ธ ์คํฌ๋ฆฐ์ท
๐ง ๊ด๋ จ ์ด์
๐ ๏ธ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๋ฆฌ์คํธ
โ ์ต์ข ๋ฐฐํฌ ์ ๊ฒ ๊ฒฐ๊ณผ